Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new package pocache #5461

Merged
merged 3 commits into from
Nov 9, 2024
Merged

Conversation

bnkamalesh
Copy link
Contributor

@bnkamalesh bnkamalesh commented Oct 28, 2024

We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.

Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link.
  • The repo documentation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • Continuous integration is used to attempt to catch issues prior to releasing this package to end-users.

Please provide some links to your package to ease the review

Pull Request content

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.

Please delete one of the following lines:

  • The packages around my addition still meet the Quality Standards.

Thanks for your PR, you're awesome! 😎

Copy link

Thank you for contributing to awesome-go. We will review your contribution as soon as possible.

Make sure you add the links in the body of the pull request that are requested in the contribution guide:

  • repo link
  • pkg.go.dev
  • goreportcard.com
  • coverage

Your project is under review. It may take a few days to be approved.

@bnkamalesh bnkamalesh changed the title added new package pocache and removed remember-go added new package pocache Oct 28, 2024
@ccoVeille
Copy link

Thanks for sharing. It looks like a good project

@bnkamalesh
Copy link
Contributor Author

bnkamalesh commented Nov 8, 2024

hey @phanirithvij any help here?

p.s: tagging you since you merged my previous PR 😅

@phanirithvij
Copy link
Collaborator

phanirithvij commented Nov 9, 2024

Apologies, we have a new hard rule against accepting < 5 months old projects.
I can ask you to re-submit it in 5 months.
Or we can keep this pr open and I will label it appropriately.

@phanirithvij
Copy link
Collaborator

Since this was requested to be added before this rule change, I can accept it.

@phanirithvij phanirithvij merged commit 4cc79fa into avelino:main Nov 9, 2024
4 checks passed
@phanirithvij phanirithvij added done reviewed and/or end of discussion (helpful label for maintainers) and removed pending-review re-submit in 5 months before labels Nov 9, 2024
@phanirithvij phanirithvij mentioned this pull request Nov 9, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done reviewed and/or end of discussion (helpful label for maintainers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants